Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: pre-fill delivery address for guest users #17561

Conversation

kpawelczak
Copy link
Contributor

@kpawelczak kpawelczak commented Jun 22, 2023

The checkout config has a new option "guestUseSavedAddress"

BREAKING CHANGE:

Checkout config has a new option; CheckoutConfigService is injected in a constructor of CheckoutDeliveryAddressComponent.

Closes: https://jira.tools.sap/browse/CXSPA-3591

@kpawelczak kpawelczak requested a review from a team as a code owner June 22, 2023 12:31
@github-actions github-actions bot marked this pull request as draft June 22, 2023 12:31
@kpawelczak kpawelczak marked this pull request as ready for review June 22, 2023 12:37
@github-actions github-actions bot marked this pull request as draft June 22, 2023 12:45
@kpawelczak kpawelczak marked this pull request as ready for review June 23, 2023 09:18
@cypress
Copy link

cypress bot commented Jun 23, 2023

3 flaky tests on run #40858 ↗︎

0 117 4 0 Flakiness 3

Details:

Merge fb0f561 into eebc403...
Project: spartacus Commit: 59cbeb310b ℹ️
Status: Passed Duration: 07:16 💡
Started: Jun 23, 2023 9:32 AM Ended: Jun 23, 2023 9:40 AM
Flakiness  cypress/e2e/ssr/pages.core-e2e.cy.ts • 3 flaky tests • SSR

View Output Video

Test Artifacts
SSR > should render homepage Output Screenshots
SSR > should render PLP Output Screenshots
SSR > should render PDP Output Screenshots

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

@github-actions github-actions bot marked this pull request as draft July 3, 2023 13:47
@kpawelczak kpawelczak changed the base branch from develop-6.2.x to develop-6.3.x July 5, 2023 08:43
@kpawelczak kpawelczak changed the base branch from develop-6.3.x to develop-6.2.x July 5, 2023 08:44
@kpawelczak
Copy link
Contributor Author

closing in favor of #17607

@kpawelczak kpawelczak closed this Jul 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant